Conversation
Sets up a dev container docker image for cross-platform compatibility and portability of the developer environment
* Added the SHELL environment variable to make pnpm happy * Removed extraneous dependencies, like perl, python, and zsh * If desired, those could be added later
JoshElias
left a comment
JoshElias
left a comment
There was a problem hiding this comment.
Looks cool. I need clarification on a few things before merging. Also, how can I test?
| export IN_VSCODE=true; | ||
| fi | ||
|
|
||
| ### Exit early if setup is handled by others |
There was a problem hiding this comment.
I'll need this mechanism explained to me. The difference of running in Docker, Vs Code or neither. Maybe we can get on a call tomorrow?
| "settings": { | ||
| "terminal.integrated.shell.linux": "/bin/zsh" | ||
| }, | ||
| "extensions": [ |
There was a problem hiding this comment.
Are these all the vs code plugins you're bundling in the container? I thought vs code was still running locally?
There was a problem hiding this comment.
No, not bundling. These are just settings that get loaded when you load the container. This tells vscode to install these extensions (but only in the context of the container).
There's still a few in here I meant to remove, I just noticed...
There was a problem hiding this comment.
That's kinda what I meant. Inside the container, vs code is being bundled with all those extensions. I'll read more on Dev Containers but clarification on them is a big part of our call today.
| "VSCODE": "true" | ||
| }, | ||
| "mounts": [ | ||
| "source=${localWorkspaceFolder}/../,target=/workspaces,type=bind,consistency=cached" |
There was a problem hiding this comment.
Is this mounting whatever folder contains all your projects?
There was a problem hiding this comment.
That is the goal, yes. I figure that the parent folder of the SmartOrder project would the one. Alternatively, we could have a different repo host them all, and this stuff would just sit in the top of it. The other 3 could be subrepositories
There was a problem hiding this comment.
Extensions need to be duplicated here and in devcontainer.json?
There was a problem hiding this comment.
This file actually needs to go away
JoshElias
left a comment
JoshElias
left a comment
There was a problem hiding this comment.
This is looking better the more I look into it. The Docker configs are very pure and if you had to implement this yourself, you'd want to do things how they are. Looks like a good superset.
|
Getting the following error after trying to use the vs code plugin Command failed: /opt/microsoft/vscode/code /home/josh/.vscode/extensions/ms-vscode-remote.remote-containers-0.348.0/dist/spec-node/devContainersSpecCLI.js up --user-data-folder /home/josh/.config/Code/User/globalStorage/ms-vscode-remote.remote-containers/data --container-session-data-folder /tmp/devcontainers-f4221a2b-11d0-42b9-9dda-6fe2e335115e1710521006196 --workspace-folder /home/josh/Projects/SmartOrder --workspace-mount-consistency cached --id-label devcontainer.local_folder=/home/josh/Projects/SmartOrder --id-label devcontainer.config_file=/home/josh/Projects/SmartOrder/.devcontainer/devcontainer.json --log-level debug --log-format json --config /home/josh/Projects/SmartOrder/.devcontainer/devcontainer.json --default-user-env-probe loginInteractiveShell --mount type=volume,source=vscode,target=/vscode,external=true --mount type=bind,source=/run/user/1000/wayland-1,target=/tmp/vscode-wayland-d1403961-b4f1-4763-8d23-d64059369a34.sock --skip-post-create --update-remote-user-uid-default on --mount-workspace-git-root |
|
It's asking me to "Install in DevContainer"? Is this why we have a million extensions in our config? Because you use every vs code plugin imaginable?
|
Lmao, I went in a bit of a tangent with the c# / .net stuff. Thought I would look them over with you and see which, if any, would be helpful |
2 participants
Description
Adds a dev container to the SmartOrder repository. This should improve developer experience, by way of the following benefits:
as well as make the tooling universal.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Checklist: